Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table, executor: set a real enum as the default enum value (#8469) #8476

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Nov 27, 2018

What problem does this PR solve?

Cherry pick #8469 to release 2.0.


This change is Reviewable

@jackysp
Copy link
Member Author

jackysp commented Nov 27, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member Author

jackysp commented Nov 28, 2018

PTAL @crazycs520

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 28, 2018
@zz-jason zz-jason merged commit a2ec9e9 into pingcap:release-2.0 Nov 28, 2018
@jackysp jackysp deleted the def_enum_2.0 branch April 4, 2019 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants