planner/core,session: fix privilege check for update #8376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the statement: "update t1,t2 set t1.id = t2.id" TiDB should check update privilege for t1 and select privilege for t2, Fix a bug that it checks update privilege for both t1 and t2
|
/run-all-tests |
|
/run-sqllogic-test |
yu34po
pushed a commit
to yu34po/tidb
that referenced
this pull request
Nov 22, 2018
In the statement: "update t1,t2 set t1.id = t2.id" TiDB should check update privilege for t1 and select privilege for t2, Fix a bug that it checks update privilege for both t1 and t2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In the statement: "update t1,t2 set t1.id = t2.id"
TiDB should check update privilege for t1 and select privilege for t2,
Fix a bug that it checks update privilege for both t1 and t2
What is changed and how it works?
Check update privilege for the Columns in the Assignment expression
Check select privilege for the table lists the update statement visit
Check List
Tests
@jackysp @XuHuaiyu
This change is