Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: make TestSchemaValidator stable #8334

Merged
merged 2 commits into from
Nov 20, 2018
Merged

domain: make TestSchemaValidator stable #8334

merged 2 commits into from
Nov 20, 2018

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Nov 15, 2018 •
edited by c4pt0r
Loading

What problem does this PR solve?

Make TestSchemaValidator stable.

FAIL: schema_validator_test.go:30: testSuite.TestSchemaValidator
schema_validator_test.go:66:
    c.Assert(valid, Equals, ResultUnknown)
... obtained domain.checkResult = 0
... expected domain.checkResult = 2

What is changed and how it works?

Make sure that ts has timed out a lease and add comments.

Related changes

  • Need to cherry-pick to the release branch

This change is Reviewable

shenli
shenli reviewed Nov 15, 2018
View reviewed changes
domain/schema_validator_test.go
@@ -63,10 +64,12 @@ func (*testSuite) TestSchemaValidator(c *C) {
validator.Restart()

// Sleep for a long time, check schema is invalid.
ts := <-oracleCh // Make sure that ts has timed out a lease.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move the comment to line 68?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It's used to comment line67-69.

@tiancaiamao
Copy link
Contributor

/run-integration-ddl-test

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 20, 2018
zz-jason
zz-jason approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 20, 2018
@zz-jason zz-jason merged commit 4ff58ea into pingcap:master Nov 20, 2018
lysu added a commit that referenced this pull request Nov 20, 2018
@lysu
Revert "domain: make TestSchemaValidator stable (#8334)"
cefae80 
This reverts commit 4ff58ea.
@zimulala zimulala deleted the schema-stable branch November 20, 2018 13:56
zimulala added a commit to zimulala/tidb that referenced this pull request Nov 22, 2018
@zimulala
domain: make TestSchemaValidator stable (pingcap#8334)
f320f2e
@zimulala zimulala mentioned this pull request Nov 22, 2018
Merged
zimulala added a commit to zimulala/tidb that referenced this pull request Nov 22, 2018
@zimulala
domain: make TestSchemaValidator stable (pingcap#8334)
bea810c
@zimulala zimulala mentioned this pull request Nov 22, 2018
Merged
zz-jason pushed a commit that referenced this pull request Nov 23, 2018
@zimulala @zz-jason
domain: make TestSchemaValidator stable (#8334) (#8408)
869e5d1
zz-jason pushed a commit that referenced this pull request Nov 24, 2018
@zimulala @zz-jason
domain: make TestSchemaValidator stable (#8334) (#8409)
a804be8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenli shenli shenli left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/test status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zimulala @tiancaiamao @shenli @zz-jason