Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix expression rewriter wrong compare logic (#8269) #8288

Merged
merged 2 commits into from
Nov 13, 2018
Merged

planner: fix expression rewriter wrong compare logic (#8269) #8288

merged 2 commits into from
Nov 13, 2018

Conversation

imtbkcat
Copy link

cherry-pick #8269

@imtbkcat imtbkcat added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/2.0 cherry-pick labels Nov 13, 2018
@imtbkcat imtbkcat requested a review from XuHuaiyu November 13, 2018 03:30
@XuHuaiyu
Copy link
Contributor

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

XuHuaiyu
XuHuaiyu reviewed Nov 13, 2018
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat imtbkcat requested a review from zz-jason November 13, 2018 03:34
eurekaka
eurekaka approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 13, 2018
@imtbkcat
Copy link
Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@imtbkcat imtbkcat added status/all tests passed and removed sig/planner SIG: Planner labels Nov 13, 2018
@jackysp jackysp merged commit 162fa84 into pingcap:release-2.0 Nov 13, 2018
@imtbkcat imtbkcat deleted the rcmpcherrypick branch November 13, 2018 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@eurekaka eurekaka eurekaka approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imtbkcat @XuHuaiyu @eurekaka @jackysp