store/tikv: Make maxTxnTimeUse a configurable value (#8215) #8209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
|
/run-integration-tests tikv=release-2.0 |
|
LGTM. |
|
/run-all-tests pd=release-2.0 tikv=release-2.0 tidb-test=release-2.0 |
|
I'll also bring this thing to master. |
Signed-off-by: MyonKeminta <[email protected]>
|
Ah.. sorry.. I forgot to sort imports and pushed again.. |
|
@MyonKeminta We'd better change the master branch firstly, then cherry pick the commit to the release-2.1 and release-2.0. |
zz-jason
changed the title
|
lGTM |
zz-jason
approved these changes
Nov 12, 2018
|
/run-all-tests pd=release-2.0 tikv=release-2.0 tidb-test=release-2.0 |
|
@zz-jason Tag this PR as release blocker? |
|
@MyonKeminta No need to, we are not going to release a new version on the 2.0 branch. |
|
/run-all-tests pd=release-2.0 tikv=release-2.0 tidb-test=release-2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: MyonKeminta [email protected]
What problem does this PR solve?
Sometimes in an olap senario, an
insert into selectstatement may take too long time to finish. Then themaxTxnTimeUse(590 seconds) may easily be exceeded. It's better to make it configurable.The
maxTxnTimeUseis required because we don't want the transaction be broken by GC. That's why we recommend users not to set the gc_life_time less than 10m. However we didn't really check if the gc_life_time was set too short. In this PR, I still didn't check it.What is changed and how it works?
This PR adds a field
max-txn-time-useto the config file, tikv-client` section. Then in 2pc.go use the config value instead of a constant.Check List
Tests
Code changes
Side effects
Related changes