Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain: fix memory leak for stats (#7864) #7873

Merged
merged 2 commits into from
Oct 11, 2018

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Oct 11, 2018

What problem does this PR solve?

Cherry pick #7864

What is changed and how it works?

Cherry pick #7864

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 11, 2018
@alivxxx
Copy link
Contributor Author

alivxxx commented Oct 11, 2018

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 11, 2018
@ngaut ngaut merged commit 4323e84 into pingcap:release-2.1 Oct 11, 2018
@alivxxx alivxxx deleted the memory-leak branch October 11, 2018 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants