ast, plan: return error when the arg of VALUES() function is not a column #7817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
eurekaka
reviewed
Sep 29, 2018
| case *ast.ValuesExpr: | ||
| if v.Column == nil { | ||
| g.err = ErrUnknownColumn.GenWithStackByArgs("", "VALUES() function") | ||
| } |
There was a problem hiding this comment.
For ValuesExpr, if v.Column is valid, shall we extract it and return this valid ColumnNameExpr as what we do in PositionExpr branch?
There was a problem hiding this comment.
Seems not.
i.e.
MySQL:
set @@sql_mode='only_full_group_by';
mysql> SELECT a AS b FROM t GROUP BY VALUES(b);
ERROR 1055 (42000): Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'test.t.a' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_byIf we return ColumnNameExpr here, the check for only_full_group_by will be passed, this is not compatible with MySQL.
There was a problem hiding this comment.
related issue:
#7822
ast/expressions.go
Outdated
| @@ -927,7 +927,10 @@ func (n *ValuesExpr) Accept(v Visitor) (Node, bool) { | |||
| if !ok { | |||
| return n, false | |||
| } | |||
| n.Column = node.(*ColumnNameExpr) | |||
| n.Column, ok = node.(*ColumnNameExpr) | |||
| if !ok { | |||
There was a problem hiding this comment.
I prefer to put this check in ColumnNameExpr branch of gbyResolver::Leave, i.e, for a ColumnNameExpr, if the extracted result is not ColumnNameExpr, we should report error.
Accept acts as a general walker, it should not involve detailed visitor logic IMHO.
|
PTAL @eurekaka |
zimulala
approved these changes
Sep 30, 2018
zimulala
added
status/LGT2
|
/run-all-tests |
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Nov 22, 2018
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Nov 22, 2018
zz-jason
pushed a commit
that referenced
this pull request
Nov 22, 2018
zz-jason
pushed a commit
that referenced
this pull request
Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL @eurekaka @winoros
What problem does this PR solve?
Before this PR:
After this PR:
What is changed and how it works?
Before this PR, we assume that the argument for VALUES must be a
ColumnNameExpr,which is promised as the example above shows.
This PR checks the type of argument for VALUES, if it's not a
ColumnNameExpr, we will raise an error.Check List
Tests
Code changes
Side effects
none
Related changes
none