Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: fix zero column size update error #7530

Merged
merged 2 commits into from
Aug 29, 2018

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Aug 29, 2018

What problem does this PR solve?

When all the column size delta is zero, there would be parse error for the insert statement.

What is changed and how it works?

Skip the update when the column size delta is zero.

Check List

Tests

  • Unit test

Code changes

  • Has unexported function/method change

Side effects

  • None

Related changes

  • None

PTAL @coocood @zz-jason @winoros

@winoros
Copy link
Member

winoros commented Aug 29, 2018

All zero means they're all NULLs?
Misread

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@winoros winoros added status/LGT1 Indicates that a PR has LGTM 1. component/statistics labels Aug 29, 2018
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Aug 29, 2018

/run-all-tests

@jackysp jackysp added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 29, 2018
@alivxxx
Copy link
Contributor Author

alivxxx commented Aug 29, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@alivxxx
Copy link
Contributor Author

alivxxx commented Aug 29, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@ngaut ngaut merged commit eef448a into pingcap:release-2.0 Aug 29, 2018
@alivxxx alivxxx deleted the zero-colsize branch August 30, 2018 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/statistics status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants