infoschema: refine infoschema's MaxLength Precision value #7463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-common-test tidb-test=pr/611 |
jackysp
reviewed
Aug 23, 2018
| @@ -792,8 +792,12 @@ func dataForColumns(ctx sessionctx.Context, schemas []*model.DBInfo) [][]types.D | |||
| func dataForColumnsInTable(schema *model.DBInfo, tbl *model.TableInfo) [][]types.Datum { | |||
| var rows [][]types.Datum | |||
| for i, col := range tbl.Columns { | |||
| var charMaxLen, charOctLen, numericPrecision, numericScale, datetimePrecision interface{} | |||
There was a problem hiding this comment.
Why not use int instead of interface{}? Are there any benefits of using interface{} here?
There was a problem hiding this comment.
using interface{}, we can got NULL result~
There was a problem hiding this comment.
yes~~we should void using interface{} as we can, but in this case is special, types.MakeDatums accept args ...interface{} as arguments.
cast to interface always happen, so direct using interface{} local variable is simple.
we also can use *int local varible instead of interface{}, but that will make us step into a well-known trap in go https://play.golang.org/p/qw6UJhvZcrR
lysu
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes #7396
What is changed and how it works?
set value for
CHARACTER_MAXIMUM_LENGTH,CHARACTER_OCTET_LENGTH,NUMERIC_PRECISION,NUMERIC_SCALE,DATETIME_PRECISIONbase on different column type.see more example in new added TestCase
Tests
Code changes
Side effects
Related changes
This change is