infoschema: fix information schema data race #7318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiancaiamao
reviewed
Aug 8, 2018
| @@ -187,31 +189,31 @@ func (b *Builder) applyCreateTable(m *meta.Meta, roDBInfo *model.DBInfo, tableID | |||
|
|
|||
| newTbl, ok := b.is.TableByID(tableID) | |||
| if ok { | |||
| roDBInfo.Tables = append(roDBInfo.Tables, newTbl.Meta()) | |||
| dbInfo.Tables = append(dbInfo.Tables, newTbl.Meta()) | |||
There was a problem hiding this comment.
Here may have the race.
| } else { | ||
| roDBInfo.Tables = append(roDBInfo.Tables[:i], roDBInfo.Tables[i+1:]...) | ||
| dbInfo.Tables = append(dbInfo.Tables[:i], dbInfo.Tables[i+1:]...) |
There was a problem hiding this comment.
Or here?
In the PR description, you'd better post the data race log, so it's easier for us to understand where is the cause of the problem.
There was a problem hiding this comment.
It actually happens here in the log, but I browse the file and find more places that may have the race.
tiancaiamao
added
status/LGT2
tiancaiamao
previously approved these changes
Aug 8, 2018
|
/run-all-tests |
|
/run-unit-test |
|
/run-all-tests |
tiancaiamao
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
When applying the changes to
DBInfo, we should not directly modify it, because it may be referenced by others.What is the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Tested in #7305
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No.
Does this PR need to be added to the release notes? (mandatory)
No.
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)
PTAL @coocood @zimulala