Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug that nullable unique index can not find null values using index. (#7163) #7172

Merged
merged 1 commit into from
Jul 29, 2018
Merged

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Jul 27, 2018

What have you changed? (mandatory)

Cherry-pick from #7163

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

ut

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

no

Does this PR affect tidb-ansible update? (mandatory)

no

Does this PR need to be added to the release notes? (mandatory)

no

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@winkyao winkyao added type/bugfix This PR fixes a bug. priority/release-blocker This issue blocks a release. Please solve it ASAP. type/2.0 cherry-pick labels Jul 27, 2018
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shenli shenli added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2018
@shenli
Copy link
Member

shenli commented Jul 27, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0 tidb-private-test=release-2.0

@shenli
Copy link
Member

shenli commented Jul 27, 2018

/run-all-tests tikv=release-2.0 tidb-test=release-2.0

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2018
@coocood coocood merged commit 1672248 into pingcap:release-2.0 Jul 29, 2018
@winkyao winkyao deleted the cherry-pick-2.0 branch July 29, 2018 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants