executor: make set system variable log shorter #7029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some application change system variable a lot, logging in short format saves disk space.
zz-jason
reviewed
Jul 10, 2018
| @@ -178,7 +178,7 @@ func (e *SetExecutor) setSysVariable(name string, v *expression.VarAssignment) e | |||
| valStr, err = value.ToString() | |||
| terror.Log(errors.Trace(err)) | |||
| } | |||
| log.Infof("[con:%d] set system variable %s = %s", sessionVars.ConnectionID, name, valStr) | |||
| log.Infof("con:%d %s=%s", sessionVars.ConnectionID, name, valStr) | |||
There was a problem hiding this comment.
do we need to keep this format [con:%d]?
There was a problem hiding this comment.
There are places where con: is not enclosed by '[]'.
How about we should remove all the [] that enclosing con:?
There was a problem hiding this comment.
should we more shorter use c: instead of conn:?
and I have a idea: maybe we encapsulation all log method and in ctx idioms, in the method body it use prealloc log header in thread load level(e.g. "c:123, tx:12, tr:33"), then need for every place to to fomat conn mannul, and no need to alloc header part every time?
zimulala
reviewed
Jul 11, 2018
session/session.go
Outdated
| @@ -986,7 +986,7 @@ func (s *session) NewTxn() error { | |||
| return errors.Trace(err) | |||
| } | |||
| vars := s.GetSessionVars() | |||
| log.Infof("[con:%d][schema ver:%d] NewTxn() inside a transaction auto commit: %d", vars.ConnectionID, vars.TxnCtx.SchemaVersion, txnID) | |||
| log.Infof("con:%d[schema ver:%d] NewTxn() inside a transaction auto commit: %d", vars.ConnectionID, vars.TxnCtx.SchemaVersion, txnID) | |||
There was a problem hiding this comment.
s/[schema ver:%d]/schema_ver:%d?
|
/run-all-tests |
zz-jason
added
type/enhancement
coocood
added
status/all tests passed
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
make set system variable log shorter
What are the type of the changes (mandatory)?
Some application change system variable a lot, logging in short format saves disk space.
How has this PR been tested (mandatory)?
Manual