executor: init builder startTS in buildTableDual
#6830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes panic when table dual is index join outer table.
|
Is there a related issue? |
|
/run-all-tests |
coocood
changed the title
newExecuorBuilderbuildTableDual
coocood
changed the title
buildTableDualbuildTableDual
|
/run-all-tests |
|
@coocood We need to cherry-pick this to the release-2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6828
What have you changed? (mandatory)
When we build an index join executor with outer table is table dual, we never call
b.getStartTSduring build time.But later when we execute the query, we use the builder to build inner table which needs
startTS, but by then, the transaction is set to invalid, then we panic.This PR init the startTS in
executorBuilder.buildTableDualto fix the panic issue.What are the type of the changes (mandatory)?
How has this PR been tested (mandatory)?