stats: fix dump stats #6285
Merged
stats: fix dump stats #6285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenli
reviewed
Apr 15, 2018
statistics/histogram.go
Outdated
| var sql string | ||
| sql = fmt.Sprintf("replace into mysql.stats_meta (version, table_id, count, modify_count) values (%d, %d, %d, %d)", version, tableID, count, modifyCount) | ||
| if _, err = exec.Execute(ctx, sql); err != nil { | ||
| return errors.Trace(err) |
There was a problem hiding this comment.
Maybe we should execute rollback here.
jackysp
reviewed
Apr 16, 2018
executor/load_stats.go
Outdated
| return nil | ||
| Err: nil, | ||
| } | ||
| err = statistics.SaveMetaToStorage(e.Ctx, tbl.TableID, tbl.Count, tbl.ModifyCount, tbl.Version) |
There was a problem hiding this comment.
I think if err is nil, we should not trace it.
There was a problem hiding this comment.
If err is nil, the errors.Trace will return nil.
|
LGTM |
|
/run-all-tests |
|
@coocood @lamxTyler PTAL |
shenli
added
status/LGT1
alivxxx
reviewed
Apr 16, 2018
executor/load_stats.go
Outdated
| @@ -143,6 +145,10 @@ func (e *LoadStatsInfo) Update(data []byte) error { | |||
| return errors.Trace(err) | |||
| } | |||
| } | |||
| err = statistics.SaveMetaToStorage(e.Ctx, tbl.TableID, tbl.Count, tbl.ModifyCount, tbl.Version) | |||
There was a problem hiding this comment.
I don't save it twice. They are two situations, and it will return immediately after the previous call.
statistics/histogram.go
Outdated
| return errors.Trace(err) | ||
| } | ||
| var sql string | ||
| sql = fmt.Sprintf("replace into mysql.stats_meta (version, table_id, count, modify_count) values (%d, %d, %d, %d)", version, tableID, count, modifyCount) |
There was a problem hiding this comment.
We cannot use the original version, it may not be loaded into stats cache.
|
/run-all-tests |
|
/run-all-tests |
alivxxx
reviewed
Apr 23, 2018
| @@ -54,6 +54,8 @@ type Handle struct { | |||
| feedback []*QueryFeedback | |||
|
|
|||
| Lease time.Duration | |||
| // loadMetaCh is a channel to notify a load stats operation has done. | |||
| loadMetaCh chan *LoadMeta | |||
There was a problem hiding this comment.
I think that it is not initialized.
coocood
added
priority/release-blocker
|
LGTM |
coocood
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two problems in the current implementation of dumping/loading stats info:
This PR fixed these issues.
PTAL @lamxTyler @coocood