Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: support cleanup dangling index data command #6102

Merged
merged 19 commits into from
Apr 2, 2018
Merged

executor: support cleanup dangling index data command #6102

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e1da0cc
admin cleanup index
jackysp Mar 20, 2018
f42bcc9
use batch
jackysp Mar 23, 2018
25f0efc
add test
jackysp Mar 23, 2018
54e5a9f
address comments
jackysp Mar 23, 2018
2919e28
resolve conflicts
jackysp Mar 23, 2018
8e4925e
limit the batch
jackysp Mar 23, 2018
1f78194
address comment
jackysp Mar 23, 2018
ee99255
Merge branch 'master' into recover_table
jackysp Mar 25, 2018
4b34f6f
Merge branch 'master' into recover_table
jackysp Mar 26, 2018
651b8c8
Merge branch 'master' into recover_table
jackysp Mar 27, 2018
4a0795c
address comments
jackysp Mar 28, 2018
2dc762a
resolve conflicts
jackysp Mar 28, 2018
e70601a
address comments
jackysp Mar 28, 2018
e5d491d
address comments
jackysp Mar 29, 2018
5d426cd
address comments
jackysp Mar 29, 2018
5989bf6
Merge branch 'master' into recover_table
jackysp Mar 31, 2018
9617686
check index by public only indices
jackysp Mar 31, 2018
303bad4
Merge branch 'master' into recover_table
jackysp Apr 2, 2018
04224eb
Merge branch 'master' into recover_table
jackysp Apr 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion executor/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,10 @@ func (b *executorBuilder) buildCleanupIndex(v *plan.CleanupIndex) Executor {
}
idxName := strings.ToLower(v.IndexName)
var index table.Index
for _, idx := range t.WritableIndices() {
for _, idx := range t.Indices() {
if idx.Meta().State != model.StatePublic {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think to do this check as line 334 is better.

continue
}
if idxName == idx.Meta().Name.L {
index = idx
break
Expand Down