Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: replace any with specific type in log #58660

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 2, 2025

What problem does this PR solve?

Issue Number: ref #31716.

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-tests-checked and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Jan 2, 2025
@rleungx
Copy link
Member Author

rleungx commented Jan 2, 2025

@hawkingrei PTAL

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 34.14634% with 27 lines in your changes missing coverage. Please review.

Project coverage is 73.9235%. Comparing base (3ac2b49) to head (c5a0e3d).
Report is 28 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58660        +/-   ##
================================================
+ Coverage   73.5500%   73.9235%   +0.3735%     
================================================
  Files          1680       1681         +1     
  Lines        464730     469681      +4951     
================================================
+ Hits         341809     347205      +5396     
+ Misses       102055     101628       -427     
+ Partials      20866      20848        -18     
Flag Coverage Δ
integration 43.2851% <14.6341%> (?)
unit 72.6624% <34.1463%> (+0.3633%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.4235% <ø> (-0.3420%) ⬇️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 3, 2025
@hawkingrei hawkingrei requested a review from xhebox January 3, 2025 03:28
Copy link

ti-chi-bot bot commented Jan 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 3, 2025
@lance6716 lance6716 changed the title *: replace any with specific type *: replace any with specific type in log Jan 3, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 3, 2025
Copy link

ti-chi-bot bot commented Jan 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-03 03:28:37.271936059 +0000 UTC m=+666652.627940602: ☑️ agreed by hawkingrei.
  • 2025-01-03 03:34:26.730062223 +0000 UTC m=+667002.086066763: ☑️ agreed by lance6716.

@lance6716
Copy link
Contributor

/cc @tangenta

@ti-chi-bot ti-chi-bot bot requested a review from tangenta January 3, 2025 03:34
@ti-chi-bot ti-chi-bot bot merged commit e18ca24 into pingcap:master Jan 3, 2025
24 checks passed
@rleungx rleungx deleted the replace-any branch January 6, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants