Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor,sessionctx: handle last_insert_id(0) like MySQL #58204

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Dec 12, 2024

What problem does this PR solve?

Issue Number: close #58201

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Handling of `last_insert_id(0)` was changed to be compatible with MySQL

@dveeden dveeden requested review from jackysp and mjonss December 12, 2024 08:32
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2024
Copy link

tiprow bot commented Dec 12, 2024

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dveeden
Copy link
Contributor Author

dveeden commented Dec 12, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 12, 2024
@dveeden
Copy link
Contributor Author

dveeden commented Dec 12, 2024

/check-issue-triage-complete

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.4754%. Comparing base (30069c5) to head (7cbe43c).
Report is 201 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58204        +/-   ##
================================================
+ Coverage   73.1633%   75.4754%   +2.3120%     
================================================
  Files          1674       1686        +12     
  Lines        461261     489468     +28207     
================================================
+ Hits         337474     369428     +31954     
+ Misses       103041      99424      -3617     
+ Partials      20746      20616       -130     
Flag Coverage Δ
integration 45.1612% <100.0000%> (?)
unit 74.2333% <100.0000%> (+1.9436%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.0100% <ø> (+0.3190%) ⬆️
parser ∅ <ø> (∅)
br 45.9370% <ø> (-0.0704%) ⬇️

Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a test as well? maybe in tests/integration?
Otherwise LGTM :)

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 13, 2024
@dveeden dveeden requested a review from mjonss December 13, 2024 05:28
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 15, 2024
@dveeden
Copy link
Contributor Author

dveeden commented Dec 15, 2024

/cc @yudongusa @benmeadowcroft

Copy link

ti-chi-bot bot commented Dec 15, 2024

@dveeden: GitHub didn't allow me to request PR reviews from the following users: yudongusa, BenMeadowcroft.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @yudongusa @benmeadowcroft

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 17, 2024
Copy link

ti-chi-bot bot commented Dec 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-15 08:10:11.18931105 +0000 UTC m=+771601.278113578: ☑️ agreed by jackysp.
  • 2024-12-17 22:11:37.331379726 +0000 UTC m=+994887.420182265: ☑️ agreed by mjonss.

@dveeden dveeden requested a review from lcwangchao December 18, 2024 15:19
Copy link

ti-chi-bot bot commented Dec 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackysp, lcwangchao, mjonss, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 27, 2024
@dveeden
Copy link
Contributor Author

dveeden commented Dec 27, 2024

/retest

Copy link

tiprow bot commented Dec 27, 2024

@dveeden: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 7cbe43c link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 0097df9 into pingcap:master Dec 27, 2024
23 of 24 checks passed
Copy link

ti-chi-bot bot commented Jan 3, 2025

@dveeden: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 7cbe43c link unknown /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect handling of last_insert_id(0)
5 participants