-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Use strict validation for stale read ts & flashback ts (#57050) #58086
*: Use strict validation for stale read ts & flashback ts (#57050) #58086
Conversation
434d805
to
9296a17
Compare
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
/retest |
[LGTM Timeline notifier]Timeline:
|
Need approvements from @wjhuang2016 @qw4990 @winoros |
/retest |
1 similar comment
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #58086 +/- ##
================================================
Coverage ? 72.4922%
================================================
Files ? 1417
Lines ? 415465
Branches ? 0
================================================
Hits ? 301180
Misses ? 94365
Partials ? 19920
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, cfzjywxk, crazycs520, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #57050
What problem does this PR solve?
Issue Number: close #56809
Problem Summary:
What changed and how does it work?
Use strict check for stale read ts & flashback ts to avoid any reading on future ts, which has risk to break the linearizability of async commit and 1PC transactions.
Pending and waiting for tikv/client-go#1484
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.