Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Use strict validation for stale read ts & flashback ts (#57050) #58086

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57050

What problem does this PR solve?

Issue Number: close #56809

Problem Summary:

What changed and how does it work?

Use strict check for stale read ts & flashback ts to avoid any reading on future ts, which has risk to break the linearizability of async commit and 1PC transactions.

Pending and waiting for tikv/client-go#1484

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 9, 2024
@MyonKeminta MyonKeminta force-pushed the cherry-pick-57050-to-release-7.5 branch from 434d805 to 9296a17 Compare December 12, 2024 07:51
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 12, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 12, 2024
Copy link

ti-chi-bot bot commented Dec 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-12 09:23:49.597170139 +0000 UTC m=+516819.685972674: ☑️ agreed by crazycs520.
  • 2024-12-12 09:35:04.189061111 +0000 UTC m=+517494.277863654: ☑️ agreed by cfzjywxk.

@cfzjywxk
Copy link
Contributor

Need approvements from @wjhuang2016 @qw4990 @winoros

@MyonKeminta
Copy link
Contributor

/retest

1 similar comment
@MyonKeminta
Copy link
Contributor

/retest

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@2061937). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #58086   +/-   ##
================================================
  Coverage               ?   72.4922%           
================================================
  Files                  ?       1417           
  Lines                  ?     415465           
  Branches               ?          0           
================================================
  Hits                   ?     301180           
  Misses                 ?      94365           
  Partials               ?      19920           
Flag Coverage Δ
unit 72.4922% <84.3750%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.6141% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, cfzjywxk, crazycs520, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 13, 2024
@ti-chi-bot ti-chi-bot bot merged commit dc56ee8 into pingcap:release-7.5 Dec 13, 2024
17 of 18 checks passed
Copy link

ti-chi-bot bot commented Dec 19, 2024

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 9296a17 link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants