-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: right deal with error for reading stats from storage #57914
base: master
Are you sure you want to change the base?
statistics: right deal with error for reading stats from storage #57914
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57914 +/- ##
================================================
+ Coverage 73.1920% 73.3700% +0.1780%
================================================
Files 1673 1703 +30
Lines 461057 469216 +8159
================================================
+ Hits 337457 344264 +6807
- Misses 102849 103487 +638
- Partials 20751 21465 +714
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b12fc2a
to
3a82e56
Compare
5276b3b
to
8955068
Compare
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
/retest |
8498af3
to
2831cb6
Compare
Signed-off-by: Weizhen Wang <[email protected]>
f472ac8
to
6d80f37
Compare
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@hawkingrei: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #57901
Problem Summary:
What changed and how does it work?
if query meets the problem, it will return null error, then it lead to delete stats. it is a bug. so we can first fix this problem first.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.