-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dumpling: use I_S to get table list for TiDB and add database to WHERE #57894
Conversation
Signed-off-by: lance6716 <[email protected]>
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57894 +/- ##
================================================
+ Coverage 72.8734% 73.6173% +0.7438%
================================================
Files 1677 1687 +10
Lines 464634 468565 +3931
================================================
+ Hits 338595 344945 +6350
+ Misses 105152 102838 -2314
+ Partials 20887 20782 -105
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #57902
Problem Summary:
What changed and how does it work?
by copilot
dumpling/export/dump.go: The logic for preparing the table list to dump has been updated to optimize the performance of reading INFORMATION_SCHEMA.TABLES for TiDB. It includes conditional checks and refactored code.
dumpling/export/sql.go: The function ListAllDatabasesTables has been refactored for improved readability and efficiency, particularly when querying INFORMATION_SCHEMA.TABLES. The function CheckIfSeqExists has been renamed to checkIfSeqExists.
dumpling/export/sql_test.go: Corresponding test cases have been updated to reflect the renaming of the function CheckIfSeqExists to checkIfSeqExists.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.