Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix query infoschema.tables table_schema/table_name with filter condition #57746

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Nov 27, 2024

What problem does this PR solve?

Issue Number: close #57657

Problem Summary:

What changed and how does it work?

There is a special optimize that if the result columns for query on INFORMATION_SCHEMA.TABLES only contains table_schema table_name, all the data are in-memory, then we have a special code path for such case #55574
But that code path differ from the main code path and miss some filter conditions, so it cause the bug in issue #57657

This fix will make the special optimize check more strick.
Only the queries for table_name table_schema columns AND WITHOUT OTHER FILTER CONDITIONS run to the special optimization.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 27, 2024
Copy link

tiprow bot commented Nov 27, 2024

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tiancaiamao tiancaiamao requested a review from tangenta November 27, 2024 02:45
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.4175%. Comparing base (0471081) to head (2875648).
Report is 3 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57746        +/-   ##
================================================
+ Coverage   72.8248%   73.4175%   +0.5926%     
================================================
  Files          1677       1677                
  Lines        464138     464190        +52     
================================================
+ Hits         338008     340797      +2789     
+ Misses       105253     102628      -2625     
+ Partials      20877      20765       -112     
Flag Coverage Δ
integration 43.3748% <90.0000%> (?)
unit 72.2365% <90.0000%> (+0.0147%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7126% <ø> (+0.0029%) ⬆️

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Benjamin2037,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 27, 2024
Copy link

ti-chi-bot bot commented Nov 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-27 02:52:46.98027361 +0000 UTC m=+604954.599928125: ☑️ agreed by tangenta.
  • 2024-11-27 05:52:55.573335801 +0000 UTC m=+615763.192990316: ☑️ agreed by Benjamin2037.

Copy link

tiprow bot commented Nov 27, 2024

@tiancaiamao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 21099b2 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tiancaiamao
Copy link
Contributor Author

/test unit-test

Copy link

tiprow bot commented Nov 27, 2024

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 09d12f0 into pingcap:master Nov 27, 2024
22 checks passed
@tiancaiamao tiancaiamao deleted the issue57657 branch November 27, 2024 15:02
@tiancaiamao tiancaiamao added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57771.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Result wrong for query select TABLE_SCHEMA from information_schema.tables where TIDB_TABLE_ID= xx
5 participants