-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: tidb_scatter_region
variable supports setting value in both upper/lower case (#57677)
#57741
ddl: tidb_scatter_region
variable supports setting value in both upper/lower case (#57677)
#57741
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57741 +/- ##
================================================
Coverage ? 57.0156%
================================================
Files ? 1770
Lines ? 627224
Branches ? 0
================================================
Hits ? 357616
Misses ? 245602
Partials ? 24006
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, benmeadowcroft, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This is an automated cherry-pick of #57677
What problem does this PR solve?
Issue Number: close #57669
Problem Summary: variable should accept upper/lower case
What changed and how does it work?
convert value from uppercase to lowercase
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.