-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: fix some problem related to stats async load #57723
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57723 +/- ##
================================================
+ Coverage 72.8126% 73.5988% +0.7862%
================================================
Files 1677 1707 +30
Lines 463954 473108 +9154
================================================
+ Hits 337817 348202 +10385
+ Misses 105277 103386 -1891
- Partials 20860 21520 +660
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
/retest |
3 similar comments
/retest |
/retest |
/retest |
Signed-off-by: Weizhen Wang <[email protected]>
7e996ce
to
14d3ae7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
/hold
Also please address the comments that I sent to you offline. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks! 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, Rustin170506 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #57722, close #57735
Problem Summary:
What changed and how does it work?
Version0 means that column stats is not created via the ANALYZE command. We should not use it to update the Last Analyze Timestamp.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.