Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: fix some problem related to stats async load #57723

Merged
merged 10 commits into from
Nov 27, 2024

Conversation

winoros
Copy link
Member

@winoros winoros commented Nov 26, 2024

What problem does this PR solve?

Issue Number: close #57722, close #57735

Problem Summary:

What changed and how does it work?

Version0 means that column stats is not created via the ANALYZE command. We should not use it to update the Last Analyze Timestamp.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

修复没有收集过统计信息的表的上次 ANALYZE 时间可能不为 NULL 的问题
Fix the issue that an unanalyzed table's last analyze time may not be NULL.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Nov 26, 2024
@winoros winoros added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 81.51986% with 107 lines in your changes missing coverage. Please review.

Project coverage is 73.5988%. Comparing base (b11d034) to head (176f67f).
Report is 16 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57723        +/-   ##
================================================
+ Coverage   72.8126%   73.5988%   +0.7862%     
================================================
  Files          1677       1707        +30     
  Lines        463954     473108      +9154     
================================================
+ Hits         337817     348202     +10385     
+ Misses       105277     103386      -1891     
- Partials      20860      21520       +660     
Flag Coverage Δ
integration 46.1872% <20.3478%> (?)
unit 72.2215% <81.5198%> (+0.0065%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <100.0000%> (ø)
parser ∅ <ø> (∅)
br 45.7036% <76.1146%> (+0.2014%) ⬆️

@winoros
Copy link
Member Author

winoros commented Nov 26, 2024

/retest

@wuhuizuo
Copy link
Contributor

/retest

3 similar comments
@wuhuizuo
Copy link
Contributor

/retest

@wuhuizuo
Copy link
Contributor

/retest

@purelind
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 27, 2024
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

/hold

Also please address the comments that I sent to you offline. Thank you!

pkg/statistics/handle/storage/read.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 27, 2024
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! 👍

pkg/statistics/handle/storage/read.go Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, Rustin170506

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 27, 2024
@winoros
Copy link
Member Author

winoros commented Nov 27, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 2b03447 into pingcap:master Nov 27, 2024
25 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #57772.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #57773.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #57774.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57775.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #57776.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
6 participants