-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix wrong calculation order of radians
(#57672)
#57687
expression: fix wrong calculation order of radians
(#57672)
#57687
Conversation
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #57687 +/- ##
================================================
Coverage ? 71.8258%
================================================
Files ? 1468
Lines ? 431817
Branches ? 0
================================================
Hits ? 310156
Misses ? 101265
Partials ? 20396
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yibin87: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, XuHuaiyu, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/rebuild |
/retest |
/retest |
1 similar comment
/retest |
This is an automated cherry-pick of #57672
What problem does this PR solve?
Issue Number: close #57671 close #57661
Problem Summary:
See #57671
What changed and how does it work?
radians changes from
arg * PI / 180
toarg * (PI / 180)
to avoid infinite float and wrong result issues. FYI: https://github.com/mysql/mysql-server/blob/ee079e5ca930ce5ed0643326abadeed8cd41fffc/sql/item_func.h#L1556 MySQL also calculatesPI / 180
firstly.TiKV has already fixed this bug in tikv/tikv#17853.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.