-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log backup: set a proper maxVersion to resolve lock (#57178) #57598
log backup: set a proper maxVersion to resolve lock (#57178) #57598
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57598 +/- ##
================================================
Coverage ? 56.8557%
================================================
Files ? 1770
Lines ? 626452
Branches ? 0
================================================
Hits ? 356174
Misses ? 246182
Partials ? 24096
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, BornChanger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
1 similar comment
/retest |
This is an automated cherry-pick of #57178
What problem does this PR solve?
Issue Number: close #57134
Problem Summary:
What changed and how does it work?
To minimize the risk of lock conflicts, set the maxVersion to be the largest existing version value across all slow regions, incremented by 1. This adjustment helps optimize RPO by proactively reducing lock contention.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.