Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variables: Increase default innodb_buffer_pool_size to 4GiB #57460

Merged

Conversation

sunxiaoguang
Copy link
Contributor

@sunxiaoguang sunxiaoguang commented Nov 18, 2024

What problem does this PR solve?

Issue Number: close #57459

image

Problem Summary: Some applications are complaining that the innodb_buffer_pool_size is too small. Since it doesn't affect any logic in TiDB, we can safely increase the default value so it will work out of box in this situation

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

The noop global variable innodb_buffer_pool_size is increased to 4GiB 

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2024
Copy link

tiprow bot commented Nov 18, 2024

Hi @sunxiaoguang. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. labels Nov 18, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5994%. Comparing base (a22b842) to head (c3ce4df).
Report is 9 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57460        +/-   ##
================================================
+ Coverage   72.8488%   73.5994%   +0.7505%     
================================================
  Files          1672       1672                
  Lines        462666     464751      +2085     
================================================
+ Hits         337047     342054      +5007     
+ Misses       104821     101916      -2905     
+ Partials      20798      20781        -17     
Flag Coverage Δ
integration 43.6553% <ø> (?)
unit 72.4234% <ø> (+0.2017%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.1962% <ø> (+0.0736%) ⬆️
---- 🚨 Try these New Features:

@sunxiaoguang sunxiaoguang changed the title variables: Increase innodb_buffer_pool_size to 4GiB variables: Increase default innodb_buffer_pool_size to 4GiB Nov 18, 2024
Copy link

ti-chi-bot bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dveeden, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 18, 2024
Copy link

ti-chi-bot bot commented Nov 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-18 08:59:10.163911328 +0000 UTC m=+865112.354780326: ☑️ agreed by hawkingrei.
  • 2024-11-18 17:48:18.480478389 +0000 UTC m=+896860.671347384: ☑️ agreed by dveeden.

@dveeden
Copy link
Contributor

dveeden commented Nov 18, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 18, 2024
@dveeden
Copy link
Contributor

dveeden commented Nov 18, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit d86a366 into pingcap:master Nov 18, 2024
24 checks passed
@sunxiaoguang sunxiaoguang deleted the increase_innodb_buffer_pool_size branch November 18, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some applications are complaining that the innodb_buffer_pool_size is too small.
3 participants