-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix resource leak in select for update when 'tidb_low_resolution_tso' is set (#57012) #57367
*: fix resource leak in select for update when 'tidb_low_resolution_tso' is set (#57012) #57367
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57367 +/- ##
================================================
Coverage ? 57.9704%
================================================
Files ? 1780
Lines ? 649750
Branches ? 0
================================================
Hits ? 376663
Misses ? 249287
Partials ? 23800
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
2 similar comments
/retest |
/retest |
This is an automated cherry-pick of #57012
What problem does this PR solve?
Issue Number: close #55468
Problem Summary:
The cause of that DATA RACE is a resource leak.
After executing "select * from low_resolution_tso for update" when
tidb_low_resolution_tso
is on,error is return but the executor is not closed, so the background goroutine leak.
The leaked goroutine still referencing session ctx.
So when the next SQL is executed, it races visiting the session ctx.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.