Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: fix the issue that the default value for BIT column is wrong (#57303) #57355

Open
wants to merge 3 commits into
base: release-7.1
Choose a base branch
from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57303

What problem does this PR solve?

Issue Number: close #57301, close #57312

Problem Summary:

  1. The CREATE TABLE statement didn't assert whether the default value for BIT is valid.
  2. The default value for BIT column is casted multiple times and may cause unexpected behavior.

What changed and how does it work?

  1. Revert part of types: convert string to MySQL BIT correctly #21310
  2. Validate the length of BIT default value.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Nov 13, 2024
Copy link

ti-chi-bot bot commented Nov 13, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 13, 2024
Signed-off-by: Yang Keao <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 5, 2024
@YangKeao YangKeao changed the title table: fix the issue that the default value for BIT column is wrong | tidb-test=pr/2424 (#57303) table: fix the issue that the default value for BIT column is wrong | tidb-test=pr/2442 (#57303) Dec 5, 2024
@YangKeao YangKeao force-pushed the cherry-pick-57303-to-release-7.1 branch from a364749 to abe18af Compare December 5, 2024 08:43
@YangKeao YangKeao changed the title table: fix the issue that the default value for BIT column is wrong | tidb-test=pr/2442 (#57303) table: fix the issue that the default value for BIT column is wrong (#57303) Dec 5, 2024
Signed-off-by: Yang Keao <[email protected]>
@YangKeao YangKeao force-pushed the cherry-pick-57303-to-release-7.1 branch from abe18af to 373e4f5 Compare December 5, 2024 11:48
@YangKeao
Copy link
Member

YangKeao commented Dec 5, 2024

/retest

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.1@a276364). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #57355   +/-   ##
================================================
  Coverage               ?   73.4621%           
================================================
  Files                  ?       1213           
  Lines                  ?     382058           
  Branches               ?          0           
================================================
  Hits                   ?     280668           
  Misses                 ?      83467           
  Partials               ?      17923           

Copy link

ti-chi-bot bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 6, 2024
Copy link

ti-chi-bot bot commented Dec 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-06 07:43:03.770100272 +0000 UTC m=+1399971.389754783: ☑️ agreed by wjhuang2016.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved do-not-merge/cherry-pick-not-approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants