Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: print callstack when exiting before preparing done (#51371) #57081

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51371

What problem does this PR solve?

Issue Number: close #51370

Problem Summary:
It is hard to debug what happens when the init pod get timed out.

What changed and how does it work?

This PR will print all gorouintes to stdout once the prepare-for-snapshot-backup command exits before finishing the full prepare stage.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

When we are not yet finished:
CleanShot 2024-02-27 at 19 28 14@2x
When we have finished prepare stage:
CleanShot 2024-02-27 at 19 28 51@2x

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: Yu Juncen <[email protected]>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 3, 2024
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 38.09524% with 26 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@2f2bf22). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #57081   +/-   ##
================================================
  Coverage               ?   72.4485%           
================================================
  Files                  ?       1415           
  Lines                  ?     414646           
  Branches               ?          0           
================================================
  Hits                   ?     300405           
  Misses                 ?      94265           
  Partials               ?      19976           
Flag Coverage Δ
unit 72.4485% <38.0952%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.5379% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 2, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 2, 2024
@BornChanger
Copy link
Contributor

/retest

Copy link

ti-chi-bot bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 2, 2024
Copy link

ti-chi-bot bot commented Dec 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-02 09:41:11.185024121 +0000 UTC m=+1061458.804678637: ☑️ agreed by BornChanger.
  • 2024-12-02 10:00:59.203321725 +0000 UTC m=+1062646.822976243: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit 8603039 into pingcap:release-7.5 Dec 2, 2024
27 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants