Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttl: fix some memory leak in TTL (#56935) #56952

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56935

What problem does this PR solve?

Issue Number: close #56934

What changed and how does it work?

fix some memory leaks in TTL

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Create 1000 TTL tables with ttl_job_interval='1m' to see the memory usage:

image

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.4 labels Oct 29, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 29, 2024
13 tasks
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.4@12a4ea9). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.4     #56952   +/-   ##
================================================
  Coverage               ?   56.2104%           
================================================
  Files                  ?       1752           
  Lines                  ?     628182           
  Branches               ?          0           
================================================
  Hits                   ?     353104           
  Misses                 ?     251161           
  Partials               ?      23917           
Flag Coverage Δ
integration 36.8158% <50.0000%> (?)
unit 72.4774% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.4162% <0.0000%> (?)

@lcwangchao
Copy link
Collaborator

/retest

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 29, 2024
Copy link

ti-chi-bot bot commented Oct 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-29 09:54:05.377802699 +0000 UTC m=+343558.216958240: ☑️ agreed by lcwangchao.
  • 2024-10-29 10:36:13.155702609 +0000 UTC m=+346085.994858155: ☑️ agreed by YangKeao.

@lcwangchao
Copy link
Collaborator

/retest

@lcwangchao lcwangchao closed this Oct 30, 2024
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants