Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: load auto id related changes for multi-schema-change diff #56873

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52967

What problem does this PR solve?

Issue Number: close #47899

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

for the case in the issue

mysql>  create table t (a int not null auto_increment primary key, b int) auto_id_cache 100;insert into t (b) values (1);
Query OK, 0 rows affected (0.09 sec)

Query OK, 1 row affected (0.01 sec)

mysql> select * from t;
+---+------+
| a | b    |
+---+------+
| 1 |    1 |
+---+------+
1 row in set (0.00 sec)

mysql> alter table t add column c int, auto_increment 200;
Query OK, 0 rows affected (0.31 sec)

mysql> insert into t (b) values (2);
Query OK, 1 row affected (0.01 sec)

mysql> select * from t;
+-----+------+------+
| a   | b    | c    |
+-----+------+------+
|   1 |    1 | NULL |
| 200 |    2 | NULL |
+-----+------+------+
2 rows in set (0.00 sec)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Oct 28, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 28, 2024
@D3Hunter D3Hunter changed the title infoschema: load auto id related changes for multi-schema-change diff | tidb-test=pr/2320 (#52967) infoschema: load auto id related changes for multi-schema-change diff Nov 4, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 8, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 8, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 8, 2024
Copy link

ti-chi-bot bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Benjamin2037,D3Hunter]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Nov 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-08 10:13:33.457834121 +0000 UTC m=+5575.648703118: ☑️ agreed by D3Hunter.
  • 2024-11-08 10:14:33.518639715 +0000 UTC m=+5635.709508711: ☑️ agreed by Benjamin2037.

infoschema/BUILD.bazel Outdated Show resolved Hide resolved
@D3Hunter
Copy link
Contributor

D3Hunter commented Nov 8, 2024

/retest

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.1@cc04dd7). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #56873   +/-   ##
================================================
  Coverage               ?   73.4845%           
================================================
  Files                  ?       1212           
  Lines                  ?     381140           
  Branches               ?          0           
================================================
  Hits                   ?     280079           
  Misses                 ?      83178           
  Partials               ?      17883           

@ti-chi-bot ti-chi-bot bot merged commit 8d4ad49 into pingcap:release-7.1 Nov 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants