-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: make table id in metrics_schema
stable
#56839
Conversation
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56839 +/- ##
=================================================
- Coverage 73.3565% 57.0776% -16.2789%
=================================================
Files 1636 1786 +150
Lines 453398 640680 +187282
=================================================
+ Hits 332597 365685 +33088
- Misses 100440 249991 +149551
- Partials 20361 25004 +4643
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, tangenta, tiancaiamao, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #56775
What changed and how does it work?
Sort tables before assign ids
Check List
Tests
Run two tidb nodes in a cluster and run below SQL in each node:
The return results are all the same.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.