planner, stats: overflow estimation may lead to wrong join reorder (#56752) #56767
+108
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #56752
What problem does this PR solve?
Issue Number: close #56704
Problem Summary:
What changed and how does it work?
When the width of the histogram is tooooo large, it's possible that
right bound - left bound
exceeds MaxFloat64. Then the width becomesinf
, and the later calculation is likely to create NaN.Join reorder uses
MaxFloat64
to do the cost comparison, which leads to the wrong order in the above extreme case.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.