-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner, stats: overflow estimation may lead to wrong join reorder (#56752) #56765
base: release-8.1
Are you sure you want to change the base?
planner, stats: overflow estimation may lead to wrong join reorder (#56752) #56765
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #56765 +/- ##
================================================
Coverage ? 71.1959%
================================================
Files ? 1468
Lines ? 423743
Branches ? 0
================================================
Hits ? 301688
Misses ? 101541
Partials ? 20514
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, qw4990, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #56752
What problem does this PR solve?
Issue Number: close #56704
Problem Summary:
What changed and how does it work?
When the width of the histogram is tooooo large, it's possible that
right bound - left bound
exceeds MaxFloat64. Then the width becomesinf
, and the later calculation is likely to create NaN.Join reorder uses
MaxFloat64
to do the cost comparison, which leads to the wrong order in the above extreme case.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.