ddl: process temp global index correctly

[Defined2014]

What problem does this PR solve?

Issue Number: close #56535

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

test with schrddl, no error report.

• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 57.2754%. Comparing base (22aa14a) to head (8a87e35).
Report is 44 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #56608         +/-   ##
=================================================
- Coverage   73.4138%   57.2754%   -16.1384%     
=================================================
  Files          1626       1778        +152     
  Lines        449042     645486     +196444     
=================================================
+ Hits         329659     369705      +40046     
- Misses        99188     250683     +151495     
- Partials      20195      25098       +4903     

Flag	Coverage Δ
integration	39.3040% <68.8888%> (?)
unit	72.6475% <80.0000%> (+0.1258%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9478% <ø> (ø)
parser	∅ <ø> (∅)
br	63.0990% <ø> (+17.5188%)	⬆️

[Defined2014]

/retest

[tiprow]

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Defined2014]

/retest

[tiprow]

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tangenta]

Rest LGTM

[Defined2014]

/retest

[tiprow]

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mjonss]

LGTM, but I wonder about what happens when you add multiple indexes with a mix of global and non-global indexes for different columns?

[mjonss]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjonss, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/ddl/OWNERS [tangenta]
• pkg/table/OWNERS [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-10-14 02:21:54.647896366 +0000 UTC m=+237711.796806200: ☑️ agreed by tangenta.
• 2024-10-14 10:30:56.738949863 +0000 UTC m=+267053.887859692: ☑️ agreed by mjonss.

[Defined2014]

/retest

[tiprow]

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Defined2014]

/retest

[tiprow]

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mjonss]

Suggested change

	// 1. All indexes are global index, the next Physical id should be the first partition id.
	// 2. Not all indexes are global index, return 0.
	// 1. All elements are global index, we are done, return 0.
	// 2. Not all indexes are global index, we need to continue with the non-global ones,
	// starting with the first partition, so the next Physical id should be the first partition id..

[Defined2014]

/retest

[tiprow]

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.