Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: reduce dumpStatsMaxDuration as 5min #56538

Merged
merged 2 commits into from
Oct 11, 2024
Merged

statistics: reduce dumpStatsMaxDuration as 5min #56538

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8a4c12
statistics: enlarge dumpStatsMaxDuration as 20min
hawkingrei Oct 10, 2024
1a3c24e
statistics: enlarge dumpStatsMaxDuration as 5min
hawkingrei Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/statistics/handle/usage/session_stats_collect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ var (
// DumpStatsDeltaRatio is the lower bound of `Modify Count / Table Count` for stats delta to be dumped.
DumpStatsDeltaRatio = 1 / 10000.0
// dumpStatsMaxDuration is the max duration since last update.
dumpStatsMaxDuration = time.Hour
dumpStatsMaxDuration = 5 * time.Minute

// batchInsertSize is the batch size used by internal SQL to insert values to some system table.
batchInsertSize = 10
Expand Down Expand Up @@ -68,7 +68,7 @@ func (s *statsUsageImpl) needDumpStatsDelta(is infoschema.InfoSchema, dumpAll bo
item.InitTime = currentTime
}
if currentTime.Sub(item.InitTime) > dumpStatsMaxDuration {
// Dump the stats to kv at least once an hour.
// Dump the stats to kv at least once 5 minutes.
return true
}
statsTbl := s.statsHandle.GetPartitionStats(tbl.Meta(), id)
Expand Down