Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: remove old, never used "IndexLookUpJoin" #5649

Merged
merged 3 commits into from
Jan 16, 2018
Merged

executor: remove old, never used "IndexLookUpJoin" #5649

merged 3 commits into from
Jan 16, 2018

Conversation

zz-jason
Copy link
Member

IndexLookUpJoin is never used since all the executors are supporting chunk execution now

@zz-jason
Copy link
Member Author

/run-all-tests

@ngaut
Copy link
Member

ngaut commented Jan 16, 2018

Nice clean up.

@zz-jason
Copy link
Member Author

/run-integration-common-test

@winoros
Copy link
Member

winoros commented Jan 16, 2018

Please rename the file. new_index_lookup_join.go->index_join.go.

@winoros
Copy link
Member

winoros commented Jan 16, 2018

/run-integration-common-test

@zz-jason
Copy link
Member Author

@coocood @winoros PTAL

@shenli
Copy link
Member

shenli commented Jan 16, 2018

LGTM

1 similar comment
@coocood
Copy link
Member

coocood commented Jan 16, 2018

LGTM

@coocood coocood merged commit d6d9419 into pingcap:master Jan 16, 2018
@zz-jason zz-jason deleted the dev/removeindexjoin branch January 16, 2018 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coocood coocood coocood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zz-jason @ngaut @winoros @shenli @coocood