stats: refine the behavior when updating stats delta #5647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
zimulala
added
status/LGT2
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
Feb 5, 2018
hanfei1991
pushed a commit
that referenced
this pull request
Feb 8, 2018
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when we updating the stats delta, there may be cases that:
tidb1 has inserted some data, but the stats delta has not been updated.
tidb2 deleted some data, then try to update the stats delta, it may fail because the
countis not accurate and raise an error likeBIGINT UNSIGNED value is out of range in '(mysql.stats_meta.count - 4)This PR fixes this by checking the
countbefore the update.