meta: introduce `metabuild.Context` to build meta #56176

lcwangchao · 2024-09-20T02:50:48Z

What problem does this PR solve?

Issue Number: close #56175

What changed and how does it work?

A new package pkg/meta/metabuild is introduced. And metabuild.Context is proposed to build metas like meta.TableInfo , meta.ColumnInfo, meta.IndexInfo, etc ...

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2024-09-20T02:51:06Z

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lcwangchao · 2024-09-20T02:56:57Z

pkg/ddl/schematracker/dm_tracker.go

@@ -182,15 +183,6 @@ func (d *SchemaTracker) CreateTable(ctx sessionctx.Context, s *ast.CreateTableSt
 	if schema == nil {
 		return infoschema.ErrDatabaseNotExists.GenWithStackByArgs(ident.Schema)
 	}
-	// suppress ErrTooLongKey
-	ctx.SetValue(ddl.SuppressErrorTooLongKeyKey, true)


SuppressErrorTooLongKeyKey is not needed now. We can specify some extra options when constructing metabuild.Context

codecov · 2024-09-20T03:10:17Z

Codecov Report

Attention: Patch coverage is 93.27485% with 23 lines in your changes missing coverage. Please review.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #56176        +/-   ##
================================================
+ Coverage   73.4321%   76.1978%   +2.7656%     
================================================
  Files          1605       1629        +24     
  Lines        445810     454140      +8330     
================================================
+ Hits         327368     346045     +18677     
+ Misses        98386      86639     -11747     
- Partials      20056      21456      +1400

Flag	Coverage Δ
integration	`51.8490% <78.3625%> (?)`
unit	`72.6037% <88.8888%> (+0.0888%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9478% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`63.0736% <ø> (+17.0694%)`	⬆️

lcwangchao · 2024-09-20T03:10:20Z

pkg/ddl/add_column.go

-func checkTooBigFieldLengthAndTryAutoConvert(tp *types.FieldType, colName string, sessVars *variable.SessionVars) error {
-	if sessVars != nil && !sessVars.SQLMode.HasStrictMode() && tp.GetType() == mysql.TypeVarchar {
+func checkTooBigFieldLengthAndTryAutoConvert(ctx *metabuild.Context, tp *types.FieldType, colName string) error {
+	if !ctx.GetSQLMode().HasStrictMode() && tp.GetType() == mysql.TypeVarchar {


Seems ctx here is always not nil. So I removed sessVars != nil

lcwangchao · 2024-09-20T05:23:29Z

/retest

tiprow · 2024-09-20T05:23:52Z

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lcwangchao · 2024-09-20T05:37:20Z

pkg/ddl/index.go

-		if ctx == nil || (ctx.GetSessionVars().SQLMode.HasStrictMode() && !suppressErrorTooLongKeyForSchemaTracker(ctx)) {
-			// return error in strict sql mode
+		if !suppressTooLongKeyErr {


This logic is moved outside:

https://github.com/pingcap/tidb/pull/56176/files#diff-45ad039a8b87835b475a52615355c444538d3a1f31a84d7b3ac94e15b1ce8721R101

D3Hunter

23/28

pkg/meta/metabuild/context_test.go

pkg/ddl/foreign_key.go

YangKeao

LGTM

ti-chi-bot · 2024-09-25T02:26:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, XuHuaiyu, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [D3Hunter,XuHuaiyu,YangKeao]
~~pkg/ddl/OWNERS~~ [D3Hunter]
~~pkg/distsql/OWNERS~~ [XuHuaiyu]
~~pkg/expression/OWNERS~~ [XuHuaiyu]
~~pkg/meta/OWNERS~~ [D3Hunter]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lcwangchao · 2024-09-25T05:50:21Z

/retest

tiprow · 2024-09-25T05:50:43Z

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lcwangchao · 2024-09-25T06:50:51Z

/retest

tiprow · 2024-09-25T06:51:13Z

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lcwangchao · 2024-09-25T10:40:44Z

/retest

tiprow · 2024-09-25T10:41:05Z

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lcwangchao · 2024-09-25T11:25:05Z

/retest

tiprow · 2024-09-25T11:25:27Z

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lcwangchao · 2024-09-25T12:42:49Z

/retest

tiprow · 2024-09-25T12:43:13Z

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

purelind · 2024-09-25T12:55:04Z

/retest

tiprow · 2024-09-25T12:55:32Z

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lcwangchao · 2024-09-25T13:59:42Z

/retest

tiprow · 2024-09-25T14:00:09Z

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lcwangchao · 2024-09-25T14:50:43Z

/retest

tiprow · 2024-09-25T14:51:06Z

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 20, 2024

lcwangchao force-pushed the metabuildctx branch from ddfbd74 to 9a72c6a Compare September 20, 2024 02:53

lcwangchao commented Sep 20, 2024

View reviewed changes

lcwangchao force-pushed the metabuildctx branch from 9a72c6a to 6b2441a Compare September 20, 2024 03:09

lcwangchao commented Sep 20, 2024

View reviewed changes

lcwangchao force-pushed the metabuildctx branch 4 times, most recently from 8474a0b to c734008 Compare September 20, 2024 04:13

lcwangchao commented Sep 20, 2024

View reviewed changes

lcwangchao force-pushed the metabuildctx branch 2 times, most recently from 8181ee9 to bf1051f Compare September 20, 2024 06:12

lcwangchao requested review from D3Hunter, tangenta and YangKeao September 20, 2024 07:28

D3Hunter reviewed Sep 23, 2024

View reviewed changes

pkg/meta/metabuild/context_test.go Outdated Show resolved Hide resolved

pkg/ddl/foreign_key.go Outdated Show resolved Hide resolved

meta: introduce metabuild.Context to build meta

3fc178d

lcwangchao force-pushed the metabuildctx branch from bf1051f to 1fba79d Compare September 23, 2024 06:33

subtest

1b29cfa

lcwangchao force-pushed the metabuildctx branch 2 times, most recently from 9d24559 to 80f39cc Compare September 23, 2024 07:09

update ttl check

9f4c7e9

lcwangchao force-pushed the metabuildctx branch from 80f39cc to 9f4c7e9 Compare September 23, 2024 07:10

YangKeao approved these changes Sep 23, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 23, 2024

ti-chi-bot bot added the approved label Sep 25, 2024

lcwangchao added 2 commits September 25, 2024 14:58

Merge branch 'master' into metabuildctx

86c612e

fix conflict after merge

a370b3a

Merge branch 'master' into metabuildctx

6dfac93

lcwangchao force-pushed the metabuildctx branch from 2e7b2da to 6dfac93 Compare September 25, 2024 12:59

lcwangchao added 4 commits September 26, 2024 04:14

Merge branch 'master' into metabuildctx

70a5a64

Merge branch 'master' into metabuildctx

1707848

make test stable

12c8658

Merge branch 'master' into metabuildctx

fd89ed4

lcwangchao force-pushed the metabuildctx branch from 407ccd5 to fd89ed4 Compare September 25, 2024 23:34

ti-chi-bot bot merged commit 7b6209d into pingcap:master Sep 26, 2024
23 checks passed

lcwangchao deleted the metabuildctx branch September 26, 2024 00:52

lcwangchao mentioned this pull request Sep 26, 2024

remove mock.Context usage in production code #53388

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

meta: introduce `metabuild.Context` to build meta #56176

meta: introduce `metabuild.Context` to build meta #56176

lcwangchao commented Sep 20, 2024

tiprow bot commented Sep 20, 2024

lcwangchao Sep 20, 2024

codecov bot commented Sep 20, 2024 •

edited

Loading

lcwangchao Sep 20, 2024

lcwangchao commented Sep 20, 2024

tiprow bot commented Sep 20, 2024

lcwangchao Sep 20, 2024

D3Hunter left a comment

YangKeao left a comment

ti-chi-bot bot commented Sep 25, 2024

lcwangchao commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

lcwangchao commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

lcwangchao commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

lcwangchao commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

lcwangchao commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

purelind commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

lcwangchao commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

lcwangchao commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

meta: introduce metabuild.Context to build meta #56176

meta: introduce metabuild.Context to build meta #56176

Conversation

lcwangchao commented Sep 20, 2024

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Sep 20, 2024

lcwangchao Sep 20, 2024

Choose a reason for hiding this comment

codecov bot commented Sep 20, 2024 • edited Loading

Codecov Report

lcwangchao Sep 20, 2024

Choose a reason for hiding this comment

lcwangchao commented Sep 20, 2024

tiprow bot commented Sep 20, 2024

lcwangchao Sep 20, 2024

Choose a reason for hiding this comment

D3Hunter left a comment

Choose a reason for hiding this comment

YangKeao left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Sep 25, 2024

lcwangchao commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

lcwangchao commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

lcwangchao commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

lcwangchao commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

lcwangchao commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

purelind commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

lcwangchao commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

lcwangchao commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

meta: introduce `metabuild.Context` to build meta #56176

meta: introduce `metabuild.Context` to build meta #56176

codecov bot commented Sep 20, 2024 •

edited

Loading