Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix br integration test (#53836) #56079

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53836

What problem does this PR solve?

Issue Number: close #53835

Problem Summary:

What changed and how does it work?

  1. fix br integration test br_txn and br_full_ddl.
  2. add br integration test for corruption of snapshot/log backup file.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Sep 13, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 13, 2024
13 tasks
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@9b45610). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #56079   +/-   ##
================================================
  Coverage               ?   72.2444%           
================================================
  Files                  ?       1415           
  Lines                  ?     414696           
  Branches               ?          0           
================================================
  Hits                   ?     299595           
  Misses                 ?      95127           
  Partials               ?      19974           
Flag Coverage Δ
unit 72.2444% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.6166% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 23, 2024
Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2024
@Leavrth
Copy link
Contributor

Leavrth commented Sep 25, 2024

/retest

1 similar comment
@Leavrth
Copy link
Contributor

Leavrth commented Sep 25, 2024

/retest

Copy link

ti-chi-bot bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 26, 2024
Copy link

ti-chi-bot bot commented Sep 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-25 05:21:43.403386577 +0000 UTC m=+1629773.143810513: ☑️ agreed by BornChanger.
  • 2024-09-26 01:27:25.543792382 +0000 UTC m=+1702115.284216315: ☑️ agreed by Leavrth.

@Leavrth
Copy link
Contributor

Leavrth commented Sep 26, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Sep 26, 2024

@Leavrth: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Leavrth
Copy link
Contributor

Leavrth commented Sep 26, 2024

/retest

1 similar comment
@Leavrth
Copy link
Contributor

Leavrth commented Sep 26, 2024

/retest

Copy link

ti-chi-bot bot commented Sep 26, 2024

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test de04eda link false /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 72eacdc into pingcap:release-7.5 Sep 26, 2024
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants