infoschema: fix snapshot read bug for information_schema.tables

[tiancaiamao]

What problem does this PR solve?

Issue Number: close #55827

Problem Summary:

What changed and how does it work?

Fix a bug introduced by #55574
That PR does not consider the snapshot read, its IterateAllTableItems funcation is always reading the latest infoschema.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.9360%. Comparing base (649dce7) to head (1ae286e).
Report is 2 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #55830         +/-   ##
=================================================
- Coverage   72.8398%   56.9360%   -15.9038%     
=================================================
  Files          1588       1738        +150     
  Lines        443554     625895     +182341     
=================================================
+ Hits         323084     356360      +33276     
- Misses       100588     245382     +144794     
- Partials      19882      24153       +4271     

Flag	Coverage Δ
integration	39.4635% <72.7272%> (?)
unit	72.4313% <100.0000%> (+0.4973%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (ø)
parser	∅ <ø> (∅)
br	52.6811% <ø> (+7.2668%)	⬆️

[tiancaiamao]

/test build

[tiprow]

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[D3Hunter]

/test pull-lightning-integration-test

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[D3Hunter]

lightning ci pass https://do.pingcap.net/jenkins/job/pingcap/job/tidb/job/pull_lightning_integration_test/1475/display/redirect

previous fail is due to when import again with physical mode, lightning got a stale and dropped table, so cannot find it after import

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/infoschema/OWNERS [D3Hunter]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-09-04 02:27:02.790211989 +0000 UTC m=+411347.308264909: ☑️ agreed by D3Hunter.
• 2024-09-04 02:45:01.319041621 +0000 UTC m=+412425.837094546: ☑️ agreed by lance6716.

[tiprow]

@tiancaiamao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	1ae286e	link	true	/test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.