-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: redact ak/sk in logging (#55622) #55779
br: redact ak/sk in logging (#55622) #55779
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #55779 +/- ##
================================================
Coverage ? 73.9431%
================================================
Files ? 1097
Lines ? 354870
Branches ? 0
================================================
Hits ? 262402
Misses ? 75882
Partials ? 16586 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
1 similar comment
/retest |
This is an automated cherry-pick of #55622
What problem does this PR solve?
Issue Number: close #55273
Problem Summary:
log-backup: secrets may be directly logging to log when --send-credentials-to-tikv=false not set during starting log backup
What changed and how does it work?
Added a wrap of the storage info and redact ak/sk, now the logging woud not print them directly.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.