Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owners: update after Rustin170506 changed GitHub ID #55760

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Aug 30, 2024

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716 lance6716 requested a review from wuhuizuo August 30, 2024 03:50
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Aug 30, 2024
Copy link

tiprow bot commented Aug 30, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716 lance6716 added the skip-issue-check Indicates that a PR no need to check linked issue. label Aug 30, 2024
@lance6716 lance6716 requested a review from Rustin170506 August 30, 2024 03:50
Copy link

ti-chi-bot bot commented Aug 30, 2024

@wuhuizuo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rustin170506, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 30, 2024
Copy link

ti-chi-bot bot commented Aug 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-30 05:46:42.19827982 +0000 UTC m=+1108397.332729941: ☑️ agreed by Rustin170506.

@ti-chi-bot ti-chi-bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 30, 2024
@wuhuizuo
Copy link
Contributor

/cherry-pick release-8.1
/cherry-pick release-7.1
/cherry-pick release-6.1
/cherry-pick release-7.5
/cherry-pick release-6.5

@ti-chi-bot
Copy link
Member

@wuhuizuo: once the present PR merges, I will cherry-pick it on top of release-6.1/release-6.5/release-7.1/release-7.5/release-8.1 in the new PR and assign it to you.

In response to this:

/cherry-pick release-8.1
/cherry-pick release-7.1
/cherry-pick release-6.1
/cherry-pick release-7.5
/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit ad5a9fd into master Aug 30, 2024
4 of 5 checks passed
@ti-chi-bot ti-chi-bot bot deleted the lance6716-patch-1 branch August 30, 2024 05:50
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-6.1: #55764.

In response to this:

/cherry-pick release-8.1
/cherry-pick release-7.1
/cherry-pick release-6.1
/cherry-pick release-7.5
/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 30, 2024
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-7.5: #55765.

In response to this:

/cherry-pick release-8.1
/cherry-pick release-7.1
/cherry-pick release-6.1
/cherry-pick release-7.5
/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 30, 2024
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-6.5: #55766.

In response to this:

/cherry-pick release-8.1
/cherry-pick release-7.1
/cherry-pick release-6.1
/cherry-pick release-7.5
/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 30, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 30, 2024
@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-8.1: #55767.

In response to this:

/cherry-pick release-8.1
/cherry-pick release-7.1
/cherry-pick release-6.1
/cherry-pick release-7.5
/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-7.1: #55768.

In response to this:

/cherry-pick release-8.1
/cherry-pick release-7.1
/cherry-pick release-6.1
/cherry-pick release-7.5
/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 30, 2024
@Rustin170506 Rustin170506 added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Sep 7, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-6.5 from head ti-chi-bot:cherry-pick-55760-to-release-6.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-6.5 and ti-chi-bot:cherry-pick-55760-to-release-6.5"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-8.1 from head ti-chi-bot:cherry-pick-55760-to-release-8.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-8.1 and ti-chi-bot:cherry-pick-55760-to-release-8.1"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.5 from head ti-chi-bot:cherry-pick-55760-to-release-7.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-7.5 and ti-chi-bot:cherry-pick-55760-to-release-7.5"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.1 from head ti-chi-bot:cherry-pick-55760-to-release-7.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-55760-to-release-7.1."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants