Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: fix the error that init stats might got failure when decoding column bucket #55685

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

winoros
Copy link
Member

@winoros winoros commented Aug 27, 2024

What problem does this PR solve?

Issue Number: close #55684

Problem Summary:

What changed and how does it work?

The old init stats doesn't handle the collation string.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 27, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 18.75000% with 26 lines in your changes missing coverage. Please review.

Project coverage is 59.4504%. Comparing base (290dc46) to head (c12dcd4).
Report is 115 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55685         +/-   ##
=================================================
- Coverage   72.9295%   59.4504%   -13.4792%     
=================================================
  Files          1581       1761        +180     
  Lines        442365     662905     +220540     
=================================================
+ Hits         322615     394100      +71485     
- Misses        99938     244752     +144814     
- Partials      19812      24053       +4241     
Flag Coverage Δ
integration 41.8544% <0.0000%> (?)
unit 75.0657% <18.7500%> (+3.0656%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.5253% <ø> (+1.5686%) ⬆️
parser ∅ <ø> (∅)
br 54.1246% <ø> (+8.6697%) ⬆️

Copy link

ti-chi-bot bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 27, 2024
Copy link

ti-chi-bot bot commented Aug 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-27 08:06:16.969055407 +0000 UTC m=+857572.103505528: ☑️ agreed by hawkingrei.
  • 2024-08-27 11:21:13.683312832 +0000 UTC m=+869268.817762950: ☑️ agreed by time-and-fate.

@winoros
Copy link
Member Author

winoros commented Aug 27, 2024

/retest

1 similar comment
@winoros
Copy link
Member Author

winoros commented Aug 28, 2024

/retest

@hawkingrei
Copy link
Member

/check-issue-triage-complete

@winoros winoros added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Aug 28, 2024
@winoros
Copy link
Member Author

winoros commented Sep 10, 2024

/retest

1 similar comment
@winoros
Copy link
Member Author

winoros commented Sep 11, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit ebf3146 into pingcap:master Sep 11, 2024
24 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #56024.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 11, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 11, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #56025.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #56026.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #56027.

ti-chi-bot bot pushed a commit that referenced this pull request Sep 12, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Sep 25, 2024
@winoros winoros deleted the init-stats-decode-failed branch November 5, 2024 19:33
ti-chi-bot bot pushed a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

init stats(lite=false) might cause sync/async stats load not worked as expected
4 participants