Lightning: add retry if transaction failed while fetching task metas

[guoshouyan]

updating this PR: #53043

What problem does this PR solve?

Issue Number: close #53042

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[sre-bot]

All committers have signed the CLA.

[ti-chi-bot]

Hi @guoshouyan. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

Hi @guoshouyan. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[guoshouyan]

Hi @lance6716 , I'm trying to update this PR and see if I can merge it, do you minding running the CI for it?

[lance6716]

/ok-to-test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.0592%. Comparing base (44f100f) to head (cd690ab).
Report is 736 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #55670         +/-   ##
=================================================
- Coverage   72.9771%   57.0592%   -15.9179%     
=================================================
  Files          1581       1761        +180     
  Lines        442336     657364     +215028     
=================================================
+ Hits         322804     375087      +52283     
- Misses        99782     257202     +157420     
- Partials      19750      25075       +5325     

Flag	Coverage Δ
integration	38.5128% <ø> (?)
unit	71.9778% <ø> (-0.0859%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (ø)
parser	∅ <ø> (∅)
br	51.5032% <ø> (+6.2240%)	⬆️

[guoshouyan]

Hi @lance6716 I try to add the ErrLockWaitTimeout as a retryable error as we spoke last time but it failed in the integration test. Could you help to shed some light on why it failed? From the log it's hard to tell why it failed

*************************** 1. row ***************************

count(i): 5000

  sum(i): 17502500

TEST FAILED: OUTPUT DOES NOT CONTAIN 'Row_count: 5000'

____________________________________

[Fri Aug 30 06:18:41 CST 2024] Executing SQL: SHOW STATS_META WHERE Table_name = 'tbl';

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

script returned exit code 1

[lance6716]

@guoshouyan The failure is not relevant to this PR. We are fixing it in master branch. The cause is we didn't run lightning CI for statistic module PR but the failure is related to statistic module.

[guoshouyan]

/retest

[guoshouyan]

@lance6716 it has passed the CI, could you take a look?

[lance6716]

Please sign CLA as the bot's instruction.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/lightning/OWNERS [D3Hunter,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-09-06 02:13:32.703411034 +0000 UTC m=+583337.221463958: ☑️ agreed by lance6716.
• 2024-09-06 03:18:41.022252209 +0000 UTC m=+587245.540305131: ☑️ agreed by D3Hunter.

[guoshouyan]

Hi @GMHDBJD , could you help to review this PR?

[tiprow]

@guoshouyan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
tidb_parser_test	cd690ab	link	true	/test tidb_parser_test
fast_test_tiprow	cd690ab	link	true	/test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[lance6716]

/retest

[lance6716]

Hi @GMHDBJD , could you help to review this PR?

This PR has enough lgtm (+1). It's blocked by CI failure. I have triggered retest.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #57917.