Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: use runtime.Version() to get Go version (#53619) #55534

Merged
merged 2 commits into from
Aug 20, 2024
Merged

util: use runtime.Version() to get Go version (#53619) #55534

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b1408d
util: use runtime.Version() to get Go version
dveeden May 28, 2024
5bf5512
Remove runtime and unsafe
dveeden May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions util/printer/printer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ import (
"bytes"
"encoding/json"
"fmt"
_ "runtime" // import link package
_ "unsafe" // required by go:linkname
"runtime"

"github.com/pingcap/tidb/config"
"github.com/pingcap/tidb/parser/mysql"
Expand All @@ -29,6 +28,12 @@ import (
"go.uber.org/zap"
)

var buildVersion string

func init() {
buildVersion = runtime.Version()
}

// PrintTiDBInfo prints the TiDB version information.
func PrintTiDBInfo() {
fields := []zap.Field{
Expand Down Expand Up @@ -178,6 +183,3 @@ func GetPrintResult(cols []string, datas [][]string) (string, bool) {
value = append(value, getPrintDivLine(maxColLen)...)
return string(value), true
}

//go:linkname buildVersion runtime.buildVersion
var buildVersion string