Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix flaky test TestRecordHistoryStatsAfterAnalyze #55365

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 12, 2024

What problem does this PR solve?

Issue Number: close #55364

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Aug 12, 2024
@hawkingrei
Copy link
Member Author

/check-issue-triage-complete

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.7553%. Comparing base (e767f86) to head (e68485b).
Report is 3 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55365        +/-   ##
================================================
+ Coverage   72.8878%   74.7553%   +1.8674%     
================================================
  Files          1572       1572                
  Lines        440058     440236       +178     
================================================
+ Hits         320749     329100      +8351     
+ Misses        99579      90974      -8605     
- Partials      19730      20162       +432     
Flag Coverage Δ
integration 48.7003% <0.0000%> (?)
unit 71.9072% <100.0000%> (-0.0119%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5538% <ø> (+6.6783%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 12, 2024
Copy link

ti-chi-bot bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 12, 2024
Copy link

ti-chi-bot bot commented Aug 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-12 09:04:11.472554818 +0000 UTC m=+172336.176024446: ☑️ agreed by AilinKid.
  • 2024-08-12 09:32:30.354024057 +0000 UTC m=+174035.057493719: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit cde5603 into pingcap:master Aug 12, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestRecordHistoryStatsAfterAnalyze
3 participants