ddl/domain: disallow set schema lease to 0

[D3Hunter]

What problem does this PR solve?

Issue Number: ref #54436

Problem Summary:

What changed and how does it work?

• disallow set schema lease to 0. set it to 0 in config is still allowwed, but will adjust it to default
• after we have MDL we can avoid the wait in DDL used for async commit and 1PC, see txn: remove the schema check and safe window related utilities after MDL is introduced #39196, so no need to depends on ddlLease=0
• move GetLease to domain, most part of ddl don't depends on the lease now
• add some comments

Check List

Tests

• Unit test, only fix existing case, doesn't add new one
• Integration test
• Manual test (add detailed scripts or steps below)

run tidb with unistore and lease=0s, run some statement, should work

make ut this pr: run all tasks takes 7m18.029994491s
make ut master: run all tasks takes 7m5.36566918s

• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.4293%. Comparing base (a541a4f) to head (41b3f1f).
Report is 19 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #55312        +/-   ##
================================================
+ Coverage   72.8356%   75.4293%   +2.5937%     
================================================
  Files          1570       1570                
  Lines        439557     441213      +1656     
================================================
+ Hits         320154     332804     +12650     
+ Misses        99659      87867     -11792     
- Partials      19744      20542       +798     

Flag	Coverage Δ
integration	50.5885% <91.8918%> (?)
unit	71.7850% <97.2973%> (-0.0847%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (ø)
parser	∅ <ø> (∅)
br	62.9544% <ø> (+17.0923%)	⬆️

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-08-09 05:55:43.377092151 +0000 UTC m=+590673.244191238: ☑️ agreed by lcwangchao.
• 2024-08-09 11:30:10.442413334 +0000 UTC m=+610740.309512421: ☑️ agreed by wjhuang2016.

[tiprow]

@D3Hunter: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	41b3f1f	link	true	/test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[D3Hunter]

/retest

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, lcwangchao, Leavrth, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Leavrth,lcwangchao,wjhuang2016]
• br/OWNERS [Leavrth]
• pkg/config/OWNERS [easonn7]
• pkg/ddl/OWNERS [wjhuang2016]
• pkg/domain/OWNERS [wjhuang2016]
• pkg/session/OWNERS [easonn7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment