Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: record get owner TS and compare it before runReorgJob quit (#55049) #55112

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #55049

What problem does this PR solve?

Issue Number: close #54897

Problem Summary:

Timeline:

  1. tidb-0 run ingest backfill workers as the DDL owner.
  2. Inject network latency to tidb-0.
  3. tidb-1 get DDL owner, and switch to merge temp index step.
  4. Inject network latency to tidb-1. tidb-1's merge temp index backfill workers failed with "DDL is not owner"
  5. tidb-0 get DDL owner AGAIN, but reorgCtx is the one added in step(1).
  6. Merge temp index step is skipped because the reorgCtx is done.

What changed and how does it work?

Record get owner TS and compare it before runReorgJob quit.

Check List

Tests

  • Unit test
  • Integration test
    Here is the log from HA test:
    image
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jul 31, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 31, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2024
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix conflicts

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 31, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 1, 2024
Copy link

ti-chi-bot bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 1, 2024
Copy link

ti-chi-bot bot commented Aug 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-31 12:49:22.920057323 +0000 UTC m=+360079.200105391: ☑️ agreed by D3Hunter.
  • 2024-08-01 03:22:58.738290104 +0000 UTC m=+412495.018338170: ☑️ agreed by tangenta.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@92e1809). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #55112   +/-   ##
================================================
  Coverage               ?   71.2860%           
================================================
  Files                  ?       1465           
  Lines                  ?     422816           
  Branches               ?          0           
================================================
  Hits                   ?     301409           
  Misses                 ?     100989           
  Partials               ?      20418           
Flag Coverage Δ
unit 71.2860% <69.5652%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.1149% <0.0000%> (?)

@tangenta
Copy link
Contributor

tangenta commented Aug 1, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 095ab5b into pingcap:release-8.1 Aug 1, 2024
18 checks passed
@wuhuizuo wuhuizuo deleted the cherry-pick-55049-to-release-8.1 branch August 1, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants