Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: remove reorg ctx when current instance is not owner #55050

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

tangenta
Copy link
Contributor

Cherry-pick #55049 to v7.5.

What problem does this PR solve?

Issue Number: close #54897

Problem Summary:

Timeline:

  1. tidb-0 run ingest backfill workers as the DDL owner.
  2. Inject network latency to tidb-0.
  3. tidb-1 get DDL owner, and switch to merge temp index step.
  4. Inject network latency to tidb-1. tidb-1's merge temp index backfill workers failed with "DDL is not owner"
  5. tidb-0 get DDL owner AGAIN, but reorgCtx is the one added in step(1).
  6. Merge temp index step is skipped because the reorgCtx is done.

What changed and how does it work?

Remove reorgCtx before quiting because of DDLNotOwner error.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2024
Copy link

tiprow bot commented Jul 30, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.5@d2304c8). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #55050   +/-   ##
================================================
  Coverage               ?   72.0060%           
================================================
  Files                  ?       1413           
  Lines                  ?     411664           
  Branches               ?          0           
================================================
  Hits                   ?     296423           
  Misses                 ?      95343           
  Partials               ?      19898           
Flag Coverage Δ
unit 72.0060% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.5383% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 30, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 30, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 30, 2024
Copy link

ti-chi-bot bot commented Jul 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-30 10:22:31.468435838 +0000 UTC m=+264867.748483902: ☑️ agreed by lance6716.
  • 2024-07-30 10:47:53.523516803 +0000 UTC m=+266389.803564873: ☑️ agreed by D3Hunter.

@tangenta
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 30, 2024
@ti-chi-bot ti-chi-bot bot merged commit 6990c1f into pingcap:release-7.5 Jul 30, 2024
18 checks passed
tangenta added a commit to ti-chi-bot/tidb that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants